Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(options): disallow additional properties and add ident to validation #346

Merged
merged 1 commit into from
Mar 17, 2018
Merged

fix(options): disallow additional properties and add ident to validation #346

merged 1 commit into from
Mar 17, 2018

Conversation

fnatte
Copy link
Contributor

@fnatte fnatte commented Mar 17, 2018 •
edited by michael-ciniawsky
Loading

Prevents unsupported options in webpack config.
Unknown properties will cause a compilation {Error}

Module build failed: ValidationError: PostCSS Loader Invalid Options

options['other'] is an invalid additional property

Type

  • Fix

SemVer

  • Bug (:label: Patch)

Checklist

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@coveralls
Copy link

coveralls commented Mar 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 87.975% when pulling b90a561 on Fnatte:fix/update-options-json into 1e0cade on postcss:master.

@michael-ciniawsky michael-ciniawsky changed the title fix(options): disallow additional properties and add ident to validation fix(options): disallow additional properties and add ident to validation Mar 17, 2018
@michael-ciniawsky michael-ciniawsky added this to the 2.1.1 milestone Mar 17, 2018
michael-ciniawsky
michael-ciniawsky approved these changes Mar 17, 2018
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fnatte Thx

@michael-ciniawsky michael-ciniawsky merged commit 82ef553 into webpack-contrib:master Mar 17, 2018
@michael-ciniawsky
Copy link
Member

Released in v2.1.2 🎉

@michael-ciniawsky michael-ciniawsky removed this from the 2.1.3 milestone Mar 17, 2018
@andrevandal andrevandal mentioned this pull request Mar 18, 2018
Closed
@koresar
Copy link

koresar commented Mar 18, 2018 •
edited
Loading

According to SemVer it should have been the v3.0.0 release. This broke many builds across the internet. Mostly Vue.js projects which include postcss by default.

Would you please revert this?

This was referenced Mar 19, 2018
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Closed
@alexander-akait
Copy link
Member

/cc @michael-ciniawsky it is breaking, need revert and release new major version 👍

This was referenced Mar 19, 2018
Closed
Merged
Closed
Closed
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 19, 2018
Closed
This was referenced Mar 19, 2018
Merged
Closed
Closed
This was referenced Mar 19, 2018
Closed
Closed
@koresar
Copy link

koresar commented Mar 20, 2018

@ai Hi Adnrey. Whole Internet is shocked with this bug. Could you please revert the PR and publish v2.1.3 it? Looks like @michael-ciniawsky is missing somewhere.

@ai
Copy link
Contributor

ai commented Mar 20, 2018

@koresar tell me more about the issue. I can remove the release from npm, but I need to clearly understand what happened to not make it worse.

@koresar
Copy link

koresar commented Mar 20, 2018 via email

@ai
Copy link
Contributor

ai commented Mar 20, 2018

@koresar it is not a “tell me more” ;). How options['useConfigFile'] is an invalid additional property is connected with this PR?

@ai
Copy link
Contributor

ai commented Mar 20, 2018

I reverted additionalProperties and released 2.1.3

@michael-ciniawsky sorry that I did it for you, emergency situation

This was referenced Mar 20, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@renovate renovate bot mentioned this pull request Mar 21, 2018
Closed
@koresar
Copy link

koresar commented Mar 22, 2018

Thank you @ai for the collaboration and dedication.

@dependencies dependencies bot mentioned this pull request Apr 1, 2018
Closed
@leecade leecade mentioned this pull request Apr 18, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 18, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 17, 2020
Merged
This was referenced Mar 28, 2020
Closed
Open
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

Assignees
No one assigned
Labels
semver: patch status: approved type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fnatte @coveralls @michael-ciniawsky @koresar @alexander-akait @ai